Skip to content

Tests and coverage #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 3, 2025
Merged

Tests and coverage #43

merged 12 commits into from
Oct 3, 2025

Conversation

@tzanko-matev
Copy link
Contributor

@tzanko-matev tzanko-matev commented Oct 2, 2025

Added more tests and started computing coverage statistics

  • ✅ Stage 0 – Baseline captured by ADR 0003 and the initial improvement plan.
  • ✅ Stage 1 – Layout Consolidation: directory moves completed, test commands
    updated, README added, and just test now runs the Rust and Python harnesses
    separately.
  • ✅ Stage 2 – Bootstrap & Output Coverage: unit tests now exercise
    TraceSessionBootstrap helpers (directory/format/argv handling) and
    TraceOutputPaths::configure_writer, with just test covering the new cases.
  • ✅ Stage 3 – Activation Guard Rails: added unit tests around
    ActivationController covering activation start, non-matching frames, and
    deactivation behaviour; existing runtime integration tests continue to pass.
  • ✅ Stage 4 – Python Unit Coverage: added tests/python/unit/test_session_helpers.py
    for facade utilities and introduced tests/python/support for shared
    fixtures; updated monitoring tests to use the helper directory builder.
  • ✅ Stage 5 – CI & Coverage Instrumentation: CI now runs the split Rust/Python
    test jobs plus a non-blocking coverage job that reuses just coverage, uploads
    LCOV/XML/JSON artefacts, and posts a per-PR summary comment.
  • ✅ Stage 6 – Cleanup & Documentation: ADR 0003 is now Accepted, top-level
    docs describe the testing/coverage workflow, and the tests README references
    the CI coverage comment for contributors.

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Coverage Summary

Rust (lines)
78.7% covered (1,854 / 2,355 | 501 missed)

File Lines Miss Cover
codetracer-python-recorder/src/code_object.rs 117 16 86.3%
codetracer-python-recorder/src/lib.rs 11 11 0.0%
codetracer-python-recorder/src/logging.rs 11 11 0.0%
codetracer-python-recorder/src/monitoring/mod.rs 69 3 95.7%
codetracer-python-recorder/src/monitoring/tracer.rs 560 188 66.4%
codetracer-python-recorder/src/runtime/activation.rs 117 9 92.3%
codetracer-python-recorder/src/runtime/frame_inspector.rs 109 24 78.0%
codetracer-python-recorder/src/runtime/logging.rs 15 4 73.3%
codetracer-python-recorder/src/runtime/mod.rs 839 100 88.1%
codetracer-python-recorder/src/runtime/output_paths.rs 80 1 98.8%
codetracer-python-recorder/src/runtime/value_capture.rs 94 58 38.3%
codetracer-python-recorder/src/runtime/value_encoder.rs 88 6 93.2%
codetracer-python-recorder/src/session.rs 54 54 0.0%
codetracer-python-recorder/src/session/bootstrap.rs 176 8 95.5%

Python (statements)
67.6% covered (96 / 142 | 46 missed)

File Stmts Miss Cover
codetracer-python-recorder/codetracer_python_recorder/__init__.py 5 0 100.0%
codetracer-python-recorder/codetracer_python_recorder/__main__.py 37 37 0.0%
codetracer-python-recorder/codetracer_python_recorder/api.py 5 0 100.0%
codetracer-python-recorder/codetracer_python_recorder/auto_start.py 20 7 65.0%
codetracer-python-recorder/codetracer_python_recorder/formats.py 13 1 92.3%
codetracer-python-recorder/codetracer_python_recorder/session.py 62 1 98.4%

Generated automatically via generate_coverage_comment.py.

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Coverage Summary

Rust (lines)
78.7% covered (1,854 / 2,355 | 501 missed)

File Lines Miss Cover
codetracer-python-recorder/src/code_object.rs 117 16 86.3%
codetracer-python-recorder/src/lib.rs 11 11 0.0%
codetracer-python-recorder/src/logging.rs 11 11 0.0%
codetracer-python-recorder/src/monitoring/mod.rs 69 3 95.7%
codetracer-python-recorder/src/monitoring/tracer.rs 560 188 66.4%
codetracer-python-recorder/src/runtime/activation.rs 117 9 92.3%
codetracer-python-recorder/src/runtime/frame_inspector.rs 109 24 78.0%
codetracer-python-recorder/src/runtime/logging.rs 15 4 73.3%
codetracer-python-recorder/src/runtime/mod.rs 839 100 88.1%
codetracer-python-recorder/src/runtime/output_paths.rs 80 1 98.8%
codetracer-python-recorder/src/runtime/value_capture.rs 94 58 38.3%
codetracer-python-recorder/src/runtime/value_encoder.rs 88 6 93.2%
codetracer-python-recorder/src/session.rs 54 54 0.0%
codetracer-python-recorder/src/session/bootstrap.rs 176 8 95.5%

Python (statements)
67.6% covered (96 / 142 | 46 missed)

File Stmts Miss Cover
codetracer-python-recorder/codetracer_python_recorder/__init__.py 5 0 100.0%
codetracer-python-recorder/codetracer_python_recorder/__main__.py 37 37 0.0%
codetracer-python-recorder/codetracer_python_recorder/api.py 5 0 100.0%
codetracer-python-recorder/codetracer_python_recorder/auto_start.py 20 7 65.0%
codetracer-python-recorder/codetracer_python_recorder/formats.py 13 1 92.3%
codetracer-python-recorder/codetracer_python_recorder/session.py 62 1 98.4%

Generated automatically via generate_coverage_comment.py.

@alehander92
Copy link
Member

alehander92 commented Oct 2, 2025

the error design document looks interesting/some maybe good ideas there: bug! with different behavior depending on the build is interesting

@tzanko-matev
Copy link
Contributor Author

tzanko-matev commented Oct 2, 2025

the error design document looks interesting/some maybe good ideas there: bug! with different behavior depending on the build is interesting

Actually those documents are from the next feature that I'm working on, I added them here by mistake. It was base on Dimo's comment about error handling issues

@alehander92
Copy link
Member

alehander92 commented Oct 2, 2025

yes: but there are still useful to know the next steps, it's not a problem that there are already committed

Base automatically changed from refactor-vc to main October 3, 2025 06:05
@tzanko-matev tzanko-matev merged commit 26e5dca into main Oct 3, 2025
3 checks passed
@tzanko-matev tzanko-matev deleted the test-and-coverage branch October 3, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alehander92 alehander92 alehander92 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tzanko-matev @alehander92